Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Added noMethodLog option #93

Closed
wants to merge 1 commit into from

Conversation

satorumpen
Copy link

I added a option do not output RPC method name.

@benjamincburns
Copy link
Contributor

Hi @satorumpen. Thanks for this contribution. Can you please explain why this change is needed?

I think rather than having special logging flags in our already overgrown options object, it's likely better to switch to a proper logging library with logging keys and log levels. I've used winston for this in the past.

@satorumpen
Copy link
Author

@benjamincburns Thanks for your reply.

I use it via ganache-cli, but I want to suppress the display of Polling method like eth_getFilterChanges. In this case, I think that the way to replace the logger with the logger option as you say is too excessive.

Please let me know your opinion.

@benjamincburns
Copy link
Contributor

@satorumpen as I said before, switching the default logger out for something more configurable (like winston) would be a more ideal approach to solving this problem. Otherwise in the interim you're welcome to set up your own logger object which filters out RPC calls you don't want to see in your logs.

If you're interested in making a contribution along those lines (adding a proper logging library) please open a new PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants