This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Align block_helper.toJSON with hashed values #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At OpenRelay, we're trying to use Ganache to test our services that are written in Go. The RPC client that ships with Geth ignores the hash provided by RPC and recalculates it instead. Due to some discrepancies between the value used to calculate the hash and the values served over RPC, the Go client is unable to compute the same hash as Ganache. Two of the issues I ran into are in Ganache core. One was that the RPC value for mixHash did not match the value used to calculate the checksum. For reasons that are not clear even after reviewing the commit history, rather than including the mixHash used to calculate the hash, block_helper was including a string of repeating "10"s. I have changed this to reflect the mixHash stored in the block header. The other issue I ran into was extraData. If block.header.extraData was an empty buffer, it would get encoded as "0x00", which decodes to a buffer containing a single null byte. When a client uses that value to compute the hash, they obviously get different results. This modifies to.rpcDataHexString to pass empty buffers through as "0x" instead of padding it with an extra 0 byte. My mission of being able to compute the same hash with Ganache and the Geth RPC client has one more stop at ethereumjs-block, which defaults to having an empty nonce instead of an appropriately sized buffer of null bytes.
|
The failing checks don't relate to the changes in this PR. At the last commit to develop, web3-providers-ws was at version 1.0.0-beta.30. By 1.0.0-beta.33 web3-provider-ws they changed the invocation of the listener function from cb(err, response) to cb(response), which is causing these tests to fail. |
Several items, difficulty, totalDifficulty, gasLimit, gasUsed, and timestamp are quantities, which the JSON RPC Spec says should not have leading 0s. to.rpcQuantityHexString() already accounts for this, but these values were not translated with rpcQuantityHexString().
AusIV
force-pushed
the
standardize-block-rpc
branch
from
266b715 to
d951cae
Compare
|
Also kudos for adding/updating the test suite - this was a very easy change to accept! |
This was referenced Apr 12, 2018
Closed
This was referenced Oct 13, 2024
This was referenced Oct 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a project where we're trying to use Ganache to test our services that
are written in Go. The RPC client that ships with Geth ignores the
hash provided by RPC and recalculates it instead. Due to some discrepancies
between the value used to calculate the hash and the values served over
RPC, the Go client is unable to compute the same hash as Ganache.
Two of the issues I ran into are in Ganache core. One was that the RPC
value for mixHash did not match the value used to calculate the checksum.
For reasons that are not clear even after reviewing the commit history,
rather than including the mixHash used to calculate the hash, block_helper
was including a string of repeating "10"s. I have changed this to reflect
the mixHash stored in the block header.
The other issue I ran into was extraData. If block.header.extraData was
an empty buffer, it would get encoded as "0x00", which decodes to a buffer
containing a single null byte. When a client uses that value to compute
the hash, they obviously get different results. This modifies
to.rpcDataHexString to pass empty buffers through as "0x" instead of
padding it with an extra 0 byte.
My mission of being able to compute the same hash with Ganache and the Geth
RPC client has one more stop at ethereumjs-block, which defaults to having
an empty nonce instead of an appropriately sized buffer of null bytes.