-
Notifications
You must be signed in to change notification settings - Fork 679
fix: add new Ethereum
types namespace to fix types
#2527
Conversation
96d6c7f
to
47d583d
Compare
Ethereum
types namespace
da81e97
to
b91fc34
Compare
Ethereum
types namespaceEthereum
types namespace to fix types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't pretend to understand those types tests, but they sure do look cool!
This was an initial pass through, I still haven't tested any of it.
// transactions | ||
export type Transaction = TransactionTypes.Transaction; | ||
export type CallTransaction = TransactionTypes.CallTransaction; | ||
export type SignedTransaction< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm having second thoughts about this name, SignedTransaction
. That name made me think it was equivalent to a raw transaction, like what eth_signTransaction
returns. :/
23c5f07
to
59a9ba0
Compare
892c68f
to
0e9642f
Compare
Co-authored-by: Micaiah Reid <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited to have this one merged! I've got some tiny clean up requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!!!
We fixed our Ethereum RPC types and put them in a new namespace:
Ethereum
! Use it as follows:If you find issues or can think of ways we can further improve our types please open a New Issue (you can view all existing type issues by filtering our issues by the typescript label).
fixes #2134