This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix: version disparity between startup/web3_clientVersion
#1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicaiahReid
changed the title
web3_clientVersion
davidmurdoch
suggested changes
Dec 8, 2021
davidmurdoch
reviewed
Dec 9, 2021
davidmurdoch
approved these changes
Dec 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with startup version being different from version received when using
web3_clientVersionby using webpack to set version environment variables on build. Uses "DEV" version as fallback when environment variables aren't availble.Positive side affect is we were able to remove ts-transformer-inline-file lib.