Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Additional fix to #51 (eth_getCode on a non-contract should return 0x) #171

Merged
merged 3 commits into from
Sep 27, 2018

Conversation

HowardBraham
Copy link
Contributor

Fixes #51

I don't think this issue was completely fixed before. In particular, the original comment was:

Not sure if this is an issue or not, but eth_getCode returns 0x0 for non-contract accounts. My assumption is that it should return 0x.

eth_getCode was still returning 0x0.

I deleted 3 lines from to.js, wrote 2 new test cases, and changed some old test cases from expecting 0x0 to expecting 0x.

Let me know if anything is wrong or missing.

@benjamincburns
Copy link
Contributor

Thanks for contributing, @HowardBraham!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zero-length unformatted data fields should return 0x, not 0x0
2 participants