This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Fix #114: Return error message if vmErrorsOnRPCResponse is disabled #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rmeissner - can you please add tests to this showing the intended behavior with and without the flag set? |
|
Sorry for my previous comment - there are already tests here! This change looks good to me. |
|
Thanks so much for your contribution, @rmeissner! |
This was referenced May 27, 2018
|
@rmeissner I just published |
|
Very cool, thank you |
This was referenced Oct 13, 2024
This was referenced Oct 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.