This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Rename blocktime to blockTime #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your diligence on this, @kosecki123! Apologies it took me a while to review, as I've been away for the past couple weeks dealing with an international move. I notice there are two tests failing in the boron build. I'm fairly sure that this is an existing bug exposed by your changes here. As a result I'll go ahead an accept this PR as-is and track down the cause of those test failures separately. Thanks again! |
|
Can you please make this into a release 🙏 |
This was referenced Oct 13, 2024
This was referenced Oct 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is missing part of #483 which renames
blocktimetoblockTimeand pass that property in options while ganache-core still expects property namedblocktimeThis PR renames
blocktimetoblockTimein ganache-core.Fixes #506