Skip to content
This repository has been archived by the owner on Sep 27, 2019. It is now read-only.

Redux saga updated #221

Conversation

MrRefactoring
Copy link
Contributor

@MrRefactoring MrRefactoring commented Apr 28, 2019

Thanks for the link to changes in redux-saga. I was able to update redux-saga

@adrianmcli adrianmcli requested a review from cds-amal April 28, 2019 17:29
@cds-amal
Copy link
Member

Thank you for this @MrRefactoring! Updating the current tests to make them pass is a great start to upgrade to redux-saga v1.0.

I want to make sure we cover our bases on a major version upgrade. This includes reviewing/changing/approving the code as conforming to the new Saga's API, where necessary and addressing outstanding sagas issues like #171, #193 and others. I think it's probably best to identify the work up front so we can more easily handle/track the work. I will tag you when that's done.

@0xTimepunk
Copy link

ETA for this? :)

Thanks for the great work

@adrianmcli
Copy link
Contributor

adrianmcli commented Jul 18, 2019

@MrRefactoring Thanks so much for making this PR! Unfortunately, we're in the process of moving over to a monorepo and this seems like a relatively simple to replicate PR for the new monorepo. Do you mind if we include this change after the move? Sorry for not addressing this PR earlier.

@MrRefactoring
Copy link
Contributor Author

@adrianmcli, yes sure

@MrRefactoring
Copy link
Contributor Author

Some of the changes moved #238 PR. It also contains changes that will lead to errors when using

@MrRefactoring MrRefactoring deleted the dependencies/redux-saga-updatae branch August 7, 2019 07:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants