Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added pattern unit tests for detectors starting with the letters p through q #3710

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Added pattern unit tests for detectors starting with the letters p through q #3710

merged 1 commit into from
Dec 2, 2024

Conversation

nabeelalam
Copy link
Contributor

@nabeelalam nabeelalam commented Dec 2, 2024 •
edited
Loading

Description:

This PR adds pattern test cases for detectors starting with the letters p through q.
It also separates non-pattern tests into its integration tests file for those detectors.

Note: The test for plaidkey requires the changes in the plaidkey detector in this PR to be merged.

Test Output:

Before plaidkey detector updates:
image

After plaidkey detector updates:
image

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@nabeelalam nabeelalam marked this pull request as ready for review December 2, 2024 12:10
@nabeelalam nabeelalam requested review from a team as code owners December 2, 2024 12:10
zricethezav
zricethezav approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@zricethezav zricethezav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

@zricethezav zricethezav merged commit 35943b4 into trufflesecurity:main Dec 2, 2024
13 checks passed
@blsaccess blsaccess mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zricethezav zricethezav zricethezav approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nabeelalam @zricethezav