Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flexport detector #3633

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add Flexport detector #3633

wants to merge 4 commits into from

Conversation

0x1
Copy link
Contributor

@0x1 0x1 commented Nov 20, 2024

Description:

This detector is for https://www.flexport.com/.
Flexport is a digital freight forwarding and logistics platform that helps businesses manage and optimize their global supply chains by providing end-to-end visibility and control over shipments.

This detector is specifically for their logistics-api. There are other APIs that we should also add.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@0x1 0x1 requested review from a team as code owners November 20, 2024 01:40
@0x1 0x1 mentioned this pull request Nov 20, 2024
2 tasks
Copy link
Contributor

@abmussani abmussani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @0x1 for the new addition in the detectors ❤️ I have a small question regarding the regex. Any reason to not put the closing word boundary ? isn't it useful to put as we already new that length of token will be 40 characters (excluding magic string).

@0x1
Copy link
Contributor Author

0x1 commented Nov 21, 2024

Thanks @0x1 for the new addition in the detectors ❤️ I have a small question regarding the regex. Any reason to not put the closing word boundary ? isn't it useful to put as we already new that length of token will be 40 characters (excluding magic string).

good catch. i had to omit the closing boundary bc unfortunately _ is a valid character for the token, but is also considered a boundary character by \b. so if we add a closing boundary the detector will not catch a lot of valid tokens, including the test tokens.

idk of a way to exclude _ from the boundary set, but if we can do so we should totally add it back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants