[scan-9] Update enumeration logic #3626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosecodym
approved these changes
Nov 22, 2024
| @@ -103,6 +103,30 @@ type SourceUnitEnumerator interface { | |||
| Enumerate(ctx context.Context, reporter UnitReporter) error | |||
| } | |||
|
|
|||
| // BaseUnitReporter is a helper struct that implements the UnitReporter interface | |||
| // and includes a JobProgress reference. | |||
| type baseUnitReporter struct { | |||
There was a problem hiding this comment.
What makes this a "base" unit reporter?
There was a problem hiding this comment.
the passed-in reporter gets wrapped into this, and so this reporter becomes the parent. 'base' made sense in that respect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to enumerate Source with Unit information. Renamed older functions to reflect new functionality.
Checklist:
make test-community)?make lintthis requires golangci-lint)?