Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SumoLogic detector #3511

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Update SumoLogic detector #3511

merged 1 commit into from
Nov 7, 2024

Conversation

rgmz
Copy link
Contributor

@rgmz rgmz commented Oct 25, 2024 •
edited
Loading

Description:

This makes a number of fixes and improvements to the SumoLogic detector.

  • Use tri-state verification
  • Update keywords
  • Improve id pattern
  • Deduplicate matches
  • Add URL pattern to detect region-specific API endpoints
  • Adds unit tests

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@rgmz rgmz force-pushed the feat/update-sumologic branch 4 times, most recently from b9069f2 to d8f87f2 Compare October 26, 2024 16:33
@rgmz rgmz marked this pull request as ready for review October 26, 2024 16:34
@rgmz rgmz force-pushed the feat/update-sumologic branch 2 times, most recently from 9798360 to 0d524f9 Compare October 27, 2024 00:39
@rgmz rgmz force-pushed the feat/update-sumologic branch from 0d524f9 to 3e5741c Compare November 3, 2024 16:18
@rgmz rgmz requested a review from a team as a code owner November 3, 2024 16:18
abmussani
abmussani reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@abmussani abmussani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rgmz for the fixes. Your changes includes implementation of the custom endpoints but tests does not include that. Can you modify unit test to cover them as well ?

@rgmz rgmz force-pushed the feat/update-sumologic branch 2 times, most recently from 6885b3a to 05bf6e1 Compare November 7, 2024 13:36
@rgmz
Copy link
Contributor Author

rgmz commented Nov 7, 2024

Your changes includes implementation of the custom endpoints but tests does not include that. Can you modify unit test to cover them as well ?

@abmussani Done!

@rgmz rgmz force-pushed the feat/update-sumologic branch from 05bf6e1 to 83740c9 Compare November 7, 2024 13:36
ahrav
ahrav approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@ahrav ahrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a single non-blocking question, otherwise looks awesome. Thanks!

@ahrav ahrav merged commit d421a94 into trufflesecurity:main Nov 7, 2024
13 checks passed
@rgmz rgmz deleted the feat/update-sumologic branch November 7, 2024 16:28
@rgmz
Copy link
Contributor Author

rgmz commented Nov 7, 2024

Just a single non-blocking question

Did you forget to leave it? Or are you referring to the existing one?

@ahrav
Copy link
Collaborator

ahrav commented Nov 7, 2024

Just a single non-blocking question

Did you forget to leave it? Or are you referring to the existing one?

errr.. lol, I guess I forgot to leave it 🤣 It wasn't really important.

@blsaccess blsaccess mentioned this pull request Nov 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abmussani abmussani abmussani left review comments

@ahrav ahrav ahrav approved these changes

Assignees
No one assigned
Labels
hacktoberfest-2024
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rgmz @ahrav @abmussani @zricethezav