Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unused logging code #3504

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Delete unused logging code #3504

merged 1 commit into from
Oct 24, 2024

Conversation

rosecodym
Copy link
Collaborator

@rosecodym rosecodym commented Oct 24, 2024 •
edited
Loading

Description:

This PR deletes code for a complicated, aspirational logging feature that we never ended up using.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@rosecodym rosecodym requested a review from a team as a code owner October 24, 2024 15:47
@rosecodym rosecodym changed the title Delete unused code Delete unused logging code Oct 24, 2024
@zricethezav
Copy link
Collaborator

love to see it folks

@zricethezav zricethezav merged commit 4cc10d3 into main Oct 24, 2024
13 checks passed
@zricethezav zricethezav deleted the delete-unused-logging-code branch October 24, 2024 15:59
@blsaccess blsaccess mentioned this pull request Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zricethezav zricethezav zricethezav approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rosecodym @zricethezav