updated gcpapplicationdefaultcredentials detector results with RawV2 #3499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abmussani
reviewed
Oct 24, 2024
There was a problem hiding this comment.
@kashifkhan0771 you might need to take a look at integration test as well.
| @@ -79,6 +79,8 @@ func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (result | |||
| s1 := detectors.Result{ | |||
| DetectorType: detectorspb.DetectorType_GCPApplicationDefaultCredentials, | |||
| Raw: []byte(detectedClientID), | |||
| RawV2: []byte(detectedClientID + creds.RefreshToken), | |||
| Redacted: creds.RefreshToken, | |||
There was a problem hiding this comment.
Should redacted field posses censored version of RefreshToken? @zricethezav I noted there is mix strategy, Some detectors are censoring, some not. Is there any particular documentation about it ?
There was a problem hiding this comment.
Shall we censor it or not @zricethezav @abmussani ?
There was a problem hiding this comment.
IMO, it should be, similar to what is done in OpenAI.
There was a problem hiding this comment.
Done @abmussani ✅
kashifkhan0771
force-pushed
the
update/gcpapplicationdefaultcreds-detector
branch
from
d5dd85e
to
8088855
Compare
zricethezav
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added refresh token in RawV2 for
gcpapplicationdefaultcredentialsdetector.JIRA Ticket:
https://trufflesecurity.atlassian.net/jira/servicedesk/projects/CSM/queues/custom/43/CSM-706
Checklist:
make test-community)?make lintthis requires golangci-lint)?