Extract FP logic correctly at other call site #3476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcastorina
approved these changes
Oct 18, 2024
ahrav
approved these changes
Oct 19, 2024
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Custom false positive logic is implemented by smuggling
CustomFalsePositiveCheckerthroughdetector.Detector. This doesn't work whendetector.Detectoris embedded insideDetectorMatch- which we caught at the other call site where this is relevant. But we have two! And this one didn't get fixed.(I want to make some time to try to figure out why the false positive logic is draped over the codebase like a dying octopus, but fixing the bug first seems prudent.)
Checklist:
make test-community)?make lintthis requires golangci-lint)?