Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: validation & verification fix for apiscience to apimetrics #3475

Merged
merged 1 commit into from
Oct 22, 2024
Merged

feat: validation & verification fix for apiscience to apimetrics #3475

merged 1 commit into from
Oct 22, 2024

Conversation

sahil9001
Copy link
Contributor

@sahil9001 sahil9001 commented Oct 18, 2024 •
edited
Loading

Description:

  • Moved apiscience to apimetrics module.
  • Updated the verification logic for token.
  • Updated the API endpoint for verification.
Screenshot 2024-10-19 at 2 38 57 AM

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@sahil9001 sahil9001 requested a review from a team as a code owner October 18, 2024 21:09
@sahil9001 sahil9001 mentioned this pull request Oct 18, 2024
Closed
2 tasks
@sahil9001
Copy link
Contributor Author

Hey @kashifkhan0771 , can you please check this, I have a lot of PRs open with no reviews

@kashifkhan0771
Copy link
Contributor

I reviewed couple of your PR's. Once those are merged/closed - will review further. Thank you for all the contribution @sahil9001.

kashifkhan0771
kashifkhan0771 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@kashifkhan0771 kashifkhan0771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sahil9001
Copy link
Contributor Author

Can you add the label here too @kashifkhan0771 ?

@zricethezav zricethezav merged commit d78239c into trufflesecurity:main Oct 22, 2024
13 checks passed
@blsaccess blsaccess mentioned this pull request Oct 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zricethezav zricethezav zricethezav approved these changes

@kashifkhan0771 kashifkhan0771 kashifkhan0771 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-2024
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sahil9001 @kashifkhan0771 @zricethezav