Extend algoliaadminkey with additional checks
#3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0x2b3bfa0 that blog is from 2020. Did you test this locally? Do you have a screenshot of the integration test passing with a valid credential? |
This comment was marked as outdated.
This comment was marked as outdated.
|
@zricethezav, locally everything seems to work "fine" now; I wonder if continuous integration will agree. 🤞🏼 |
2 tasks
0x2b3bfa0
changed the title
algoliaadminkey with ACL checksalgoliaadminkey with additional checks
0x2b3bfa0
force-pushed
the
0x2b3bfa0-patch-1
branch
from
61a2c21
to
4dc3365
Compare
0x2b3bfa0
commented
Oct 21, 2024
|
@zricethezav, I've consolidated #3458 into this pull request and made sure all tests pass. |
zricethezav
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds verification for other kinds of sensitive Algolia API keys apart from Admin keys, as per https://www.secjuice.com/api-misconfiguration-data-breach.
This pull reques also enhances the detection of Algolia keys by looking also for Algolia DocSearch keywords and option names on the official libraries (example).
Checklist
make test-community)?make lintthis requires golangci-lint)?