[analyze] Add Analyzer for MySQL #3193
Conversation
| //go:embed expected_output.json | ||
| var expectedOutput []byte |
|
This is also missing the enumerated permissions and generated types. |
Add the enumerated permission types. |
abmussani
force-pushed
the
impl-data-model-mysql
branch
from
00fa5b2 to
44c2bc6
Compare
| for _, database := range info.Databases { | ||
| dbResource := analyzers.Resource{ | ||
| Name: database.Name, | ||
| FullyQualifiedName: database.Name, |
There was a problem hiding this comment.
Does the database name include the hostname? I think this needs to be a bit more unique..
There was a problem hiding this comment.
I included the hostname in database resources FQN.
| for _, table := range *database.Tables { | ||
| tableResource := analyzers.Resource{ | ||
| Name: table.Name, | ||
| FullyQualifiedName: table.Name, |
There was a problem hiding this comment.
I think the fully qualified name should probably be <db name> / <table name>. It's supposed to be a unique identifier for this resource, right? Maybe it even needs the hostname too 🤔
There was a problem hiding this comment.
Good suggestion, I included the hostname & database name in tableresources FQN.
validation for connection string in analyzer
simplified the mysql test due to huge structure
abmussani
force-pushed
the
impl-data-model-mysql
branch
from
44c2bc6 to
e00c8dd
Compare
|
@mcastorina I have also simplified the test for mysql. |
Description:
implemented analyzer interface for Mysql.
Checklist:
make test-community)?make lintthis requires golangci-lint)?