Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-125131 / 13.1 / Always remove OAuth window event listener #9415

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

themylogin
Copy link
Contributor

cloudsync.onedrive_list_drives was called for pCloud credential. I suppose, the component was previously used to perform a OneDrive authorization and OneDrive event listener did not remove itself due to an unhandled exception.

`cloudsync.onedrive_list_drives` was called for pCloud credential. I suppose, the component was previously
used to perform a OneDrive authorization and OneDrive event listener did not remove itself due to an
unhandled exception.
@themylogin themylogin requested a review from a team as a code owner January 8, 2024 14:51
@themylogin themylogin requested review from denysbutenko and removed request for a team January 8, 2024 14:51
@bugclerk
Copy link
Contributor

bugclerk commented Jan 8, 2024

@bugclerk bugclerk changed the title Always remove OAuth window event listener NAS-125131 / 13.0 / Always remove OAuth window event listener Jan 8, 2024
@themylogin
Copy link
Contributor Author

time 0:30

@themylogin themylogin changed the base branch from truenas/13.0-stable to 13.1-stable January 8, 2024 16:45
@themylogin themylogin changed the title NAS-125131 / 13.0 / Always remove OAuth window event listener NAS-125131 / 13.1 / Always remove OAuth window event listener Jan 8, 2024
Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@undsoft
Copy link
Collaborator

undsoft commented Jan 8, 2024

Do we still support OneDrive integration in 13.1?

@themylogin
Copy link
Contributor Author

@undsoft yes

@undsoft
Copy link
Collaborator

undsoft commented Jan 8, 2024

Okay, thanks.

@undsoft undsoft merged commit c365ed2 into 13.1-stable Jan 8, 2024
3 checks passed
@undsoft undsoft deleted the NAS-125131 branch January 8, 2024 17:04
@bugclerk
Copy link
Contributor

bugclerk commented Jan 8, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants