Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131865 / 25.04 / Remove command dialog in apps shell #11067

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Nov 19, 2024

Changes:

Removes this dialog
Снимок экрана 2024-11-19 в 11 43 29

Testing:

Test changes in Workloads card in apps.

Downstream

Affects Reasoning
Documentation Removes dialog.

@undsoft undsoft requested a review from a team as a code owner November 19, 2024 10:44
@undsoft undsoft requested review from AlexKarpov98 and removed request for a team November 19, 2024 10:44
@bugclerk bugclerk changed the title NAS-131865: Remove command dialog in apps shell NAS-131865 / 25.04 / Remove command dialog in apps shell Nov 19, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.31%. Comparing base (a04d02f) to head (e220f28).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11067      +/-   ##
==========================================
+ Coverage   82.27%   82.31%   +0.04%     
==========================================
  Files        1628     1627       -1     
  Lines       57176    57121      -55     
  Branches     5905     5903       -2     
==========================================
- Hits        47039    47019      -20     
+ Misses      10137    10102      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye Bye Dialog 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants