Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132593 / 25.04 / Fix how GPU devices are added to containers #11063

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Nov 18, 2024

Changes:

virt.device.gpu_choices returns an object where keys are pci addresses that should be used to add gpus to a container.

Testing:

I am not aware of a system that we can use for testing for now, but for now you can inspect code and tests.

@undsoft undsoft requested a review from a team as a code owner November 18, 2024 14:10
@undsoft undsoft requested review from AlexKarpov98 and removed request for a team November 18, 2024 14:10
@bugclerk bugclerk changed the title NAS-132593: Fix how GPU devices are added to containers NAS-132593 / 25.04 / Fix how GPU devices are added to containers Nov 18, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.27%. Comparing base (f67d06b) to head (0cd2bac).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11063   +/-   ##
=======================================
  Coverage   82.27%   82.27%           
=======================================
  Files        1628     1628           
  Lines       57197    57199    +2     
  Branches     5905     5905           
=======================================
+ Hits        47057    47059    +2     
  Misses      10140    10140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code & tests look good 👍

@undsoft undsoft merged commit 1e7e783 into master Nov 19, 2024
9 checks passed
@undsoft undsoft deleted the NAS-132593 branch November 19, 2024 08:47
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants