Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-132581 / 25.04 / Missed code for previously merged PR #11062

Merged
merged 5 commits into from
Nov 18, 2024
Merged

NAS-132581 / 25.04 / Missed code for previously merged PR #11062

merged 5 commits into from
Nov 18, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Only approve needed.

@AlexKarpov98 AlexKarpov98 self-assigned this Nov 18, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner November 18, 2024 13:11
@AlexKarpov98 AlexKarpov98 requested review from undsoft and removed request for a team November 18, 2024 13:11
@undsoft
Copy link
Collaborator

undsoft commented Nov 18, 2024

Files changed 0. :)

@bugclerk bugclerk changed the title NAS-132581: Missed code for previously merged PR NAS-132581 / 25.04 / Missed code for previously merged PR Nov 18, 2024
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-132581

@AlexKarpov98
Copy link
Contributor Author

AlexKarpov98 commented Nov 18, 2024 •
edited
Loading

Files changed 0. :)

now 1 😄
I accidentally removed that piece of code for FT.

undsoft
undsoft approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏼

@AlexKarpov98 AlexKarpov98 merged commit 0b98218 into master Nov 18, 2024
6 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-132581 branch November 18, 2024 13:25
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@undsoft undsoft undsoft approved these changes

Assignees

@AlexKarpov98 AlexKarpov98

Labels
no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexKarpov98 @undsoft @bugclerk