Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132242 / 24.10.1 / Fix Missing NICs Can Cause Dashboard to Misbehave (by denysbutenko) #11060

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

bugclerk
Copy link
Contributor

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x c11dc493f22cb233de4e51aa34854ed7996093a6

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x 1f43e45a21f10636dee8d3ede226a72e2006d4b5

Changes:

Fix Missing NICs Can Cause Dashboard to Misbehave

Testing:

Add different network widgets and remove nic. Ensure the dashboard and whole UI is still operable.

Expected result:

image

Original PR: #11050
Jira URL: https://ixsystems.atlassian.net/browse/NAS-132242

@denysbutenko denysbutenko marked this pull request as ready for review November 18, 2024 12:17
@denysbutenko denysbutenko requested a review from a team as a code owner November 18, 2024 12:17
@denysbutenko denysbutenko requested review from RehanY147 and removed request for a team November 18, 2024 12:17
@denysbutenko denysbutenko enabled auto-merge (squash) November 18, 2024 12:17
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported

@denysbutenko denysbutenko merged commit 9cb82d8 into stable/electriceel Nov 18, 2024
5 checks passed
@denysbutenko denysbutenko deleted the NAS-132242-24.10.1 branch November 18, 2024 12:35
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants