Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132517 / 25.04 / Cloud credentials storJ text does not render link correctly #11055

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Code review is enough
Screenshot 2024-11-18 at 11 06 26

@AlexKarpov98 AlexKarpov98 self-assigned this Nov 18, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner November 18, 2024 09:06
@AlexKarpov98 AlexKarpov98 requested review from bvasilenko and removed request for a team November 18, 2024 09:06
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-132517: Cloud credentials storJ text does not render link correctly NAS-132517 / 25.04 / Cloud credentials storJ text does not render link correctly Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.97%. Comparing base (3fb4e8b) to head (cf3d06f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11055   +/-   ##
=======================================
  Coverage   81.96%   81.97%           
=======================================
  Files        1629     1629           
  Lines       57373    57373           
  Branches     5927     5927           
=======================================
+ Hits        47026    47029    +3     
+ Misses      10347    10344    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants