Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130487 / 25.04 / Switch WebUI to use new system-wide iSCSI Discovery Auth APIs #11051

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

bvasilenko
Copy link
Contributor

Changes:

On the Shares page,

  1. At the iSCSI > Wizard side panel, Removed Discovery Authentication Group dropdown boxes
  2. At the iSCSI > Configure subpage, On the Portals tab, At the Portal edit, Removed all Discovery Authentication dropdown boxes
  3. In Authorized Access form, added Discovery Authentication dropdown to the bottom of the form.
    The following options are available: ---, CHAP and CHAP Mutual.
    CHAP Mutual is only available if peer user / secret are entered.

Testing:

On the Shares page,

  1. Go through the iSCSI > Wizard
  2. Test iSCSI > Configure subpage
  3. Test the form Authorized Access

Downstream

Affects Reasoning
Documentation Reflect field removal/addition in Wizard and forms

@bvasilenko bvasilenko requested a review from a team as a code owner November 17, 2024 18:10
@bvasilenko bvasilenko requested review from denysbutenko and removed request for a team November 17, 2024 18:10
@bugclerk bugclerk changed the title Switch WebUI to use new system-wide iSCSI Discovery Auth APIs NAS-130487 / 25.04 / Switch WebUI to use new system-wide iSCSI Discovery Auth APIs Nov 17, 2024
@bugclerk
Copy link
Contributor

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bvasilenko bvasilenko enabled auto-merge (squash) November 18, 2024 11:37
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (be985f8) to head (fedc891).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11051      +/-   ##
==========================================
- Coverage   81.96%   81.93%   -0.03%     
==========================================
  Files        1629     1629              
  Lines       57369    57342      -27     
  Branches     5925     5922       -3     
==========================================
- Hits        47025    46986      -39     
- Misses      10344    10356      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bvasilenko bvasilenko merged commit 7eb21cd into master Nov 18, 2024
11 checks passed
@bvasilenko bvasilenko deleted the NAS-130487 branch November 18, 2024 12:10
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants