Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132542 / 25.04 / Allow devices to be added to containers #11046

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Nov 15, 2024

Changes:

Adds Add button to Devices card in Containers plus other minor fixes.

@undsoft undsoft requested a review from a team as a code owner November 15, 2024 15:27
@undsoft undsoft requested review from bvasilenko and removed request for a team November 15, 2024 15:28
@bugclerk bugclerk changed the title NAS-132542: Allow devices to be added to containers NAS-132542 / 25.04 / Allow devices to be added to containers Nov 15, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.97%. Comparing base (35ff82e) to head (eaeff40).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11046      +/-   ##
==========================================
+ Coverage   81.95%   81.97%   +0.02%     
==========================================
  Files        1627     1628       +1     
  Lines       57296    57354      +58     
  Branches     5923     5922       -1     
==========================================
+ Hits        46957    47018      +61     
+ Misses      10339    10336       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	src/assets/i18n/zh-hans.json
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good.

Screen.Recording.2024-11-15.at.18.11.45.mov

I think we should add some distinguishable naming for devices:
Screenshot 2024-11-15 at 18 13 49

@undsoft undsoft merged commit 021b858 into master Nov 15, 2024
11 checks passed
@undsoft undsoft deleted the NAS-132542 branch November 15, 2024 16:39
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants