NAS-132298 / 25.04 / Add Delete and Edit actions for virtualization instances #10996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexKarpov98
requested review from
denysbutenko
and removed request for
a team
bugclerk
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10996 +/- ##
==========================================
+ Coverage 82.00% 82.02% +0.02%
==========================================
Files 1615 1616 +1
Lines 56917 57004 +87
Branches 5891 5895 +4
==========================================
+ Hits 46677 46760 +83
- Misses 10240 10244 +4 ☔ View full report in Codecov by Sentry. |
undsoft
requested changes
Nov 7, 2024
|
Edit form now shows up in Slide In. 
|
undsoft
approved these changes
Nov 8, 2024
src/app/pages/virtualization/components/all-instances/instance-list/instance-list.component.ts
Outdated
Show resolved
Hide resolved
...rtualization/components/instance-wizard/select-image-dialog/select-image-dialog.component.ts
Outdated
Show resolved
Hide resolved
src/app/pages/virtualization/components/instance-wizard/instance-wizard.component.ts
Show resolved
Hide resolved
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing:
See ticket.
I fixed initial list instances loading as well, it didn't work correctly.
Known issue: Auto-start is always TRUE (unchangeable) -> William is notified about it
Result:
Screen.Recording.2024-11-07.at.12.31.09.mov