-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-130334 / 24.10 / EE: Snapshots card for TrueCloud Backup task has no 'Delete' option #10418
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10418 +/- ##
==========================================
- Coverage 76.96% 76.92% -0.05%
==========================================
Files 1608 1608
Lines 54947 54984 +37
Branches 6468 6463 -5
==========================================
+ Hits 42290 42296 +6
- Misses 12657 12688 +31 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two versions of "Snapshot deleted"
and "Snapshot deleted."
. Let's keep existing to have translations.
Looks good.
This PR has been merged and conversations have been locked. |
Changes:
Added Delete True Cloud Backup Snapshot logic.
Testing:
See ticket.
Go to the TrueCloud Backup page and hit
Run Job
button to see some snapshots on the list.Check delete snapshot functionality.
Result:
NAS-130334.mov