Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130334 / 24.10 / EE: Snapshots card for TrueCloud Backup task has no 'Delete' option #10418

Merged
merged 6 commits into from
Aug 9, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Changes:
Added Delete True Cloud Backup Snapshot logic.

Testing:
See ticket.
Go to the TrueCloud Backup page and hit Run Job button to see some snapshots on the list.
Check delete snapshot functionality.

Result:

NAS-130334.mov
Affects Reasoning
Documentation Added Delete True Cloud Backup Snapshot logic.

@AlexKarpov98 AlexKarpov98 self-assigned this Aug 9, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner August 9, 2024 06:12
@AlexKarpov98 AlexKarpov98 requested review from RehanY147 and removed request for a team August 9, 2024 06:12
@bugclerk bugclerk changed the title NAS-130334: EE: Snapshots card for TrueCloud Backup task has no 'Delete' option NAS-130334 / 24.10 / EE: Snapshots card for TrueCloud Backup task has no 'Delete' option Aug 9, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Aug 9, 2024

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.92%. Comparing base (c7ef6a1) to head (4b6d39c).
Report is 3 commits behind head on master.

Files Patch % Lines
...ckup-snapshots/cloud-backup-snapshots.component.ts 80.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10418      +/-   ##
==========================================
- Coverage   76.96%   76.92%   -0.05%     
==========================================
  Files        1608     1608              
  Lines       54947    54984      +37     
  Branches     6468     6463       -5     
==========================================
+ Hits        42290    42296       +6     
- Misses      12657    12688      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two versions of "Snapshot deleted" and "Snapshot deleted.". Let's keep existing to have translations.
Looks good.

@AlexKarpov98 AlexKarpov98 merged commit 002da50 into master Aug 9, 2024
2 of 3 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-130334 branch August 9, 2024 07:54
@bugclerk
Copy link
Contributor

bugclerk commented Aug 9, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants