NAS-130333 / 24.10 / Adds roles for app related api endpoint access elements #10417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
undsoft
approved these changes
Aug 9, 2024
| @@ -32,6 +34,7 @@ | |||
| {{ 'Manage Container Images' | translate }} | |||
| </button> --> | |||
| <button | |||
| *ixRequiredRoles="manageCatalogRequiredRoles" | |||
There was a problem hiding this comment.
This can be allowed, because there is no other way for user to see what trains are currently selected.
Related: #10408
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10417 +/- ##
==========================================
+ Coverage 76.92% 76.93% +0.01%
==========================================
Files 1622 1622
Lines 55126 55135 +9
Branches 6471 6471
==========================================
+ Hits 42407 42420 +13
+ Misses 12719 12715 -4 ☔ View full report in Codecov by Sentry. |
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Adds roles for app related api endpoint access elements
Testing:
Test from API docs that api related endpoints are not missed. Calls that are allowed for
READ_ONLY_ADMINrole are skipped as they are always allowed.