NAS-129364 / 24.10 / "There are unapplied network interface changes" window is displayed incorrectly

[AlexKarpov98]

Changes:

New warning dialog is added to inform user that we have restored the previous network configuration to ensure continued connectivity.

Testing:
See ticket.
Try updating network interface Aliases with 9.9.9.9 for example.
You can set 10 seconds to wait less time.

Result:

Downstream

Affects	Reasoning
Documentation	New dialog is added in case of Network Reconnection Issue

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-129364

[codecov]

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.15%. Comparing base (a55bcde) to head (a97f0da).
Report is 1 commits behind head on master.

Files	Patch %	Lines
src/app/pages/network/network.component.ts	60.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10396      +/-   ##
==========================================
- Coverage   77.17%   77.15%   -0.03%     
==========================================
  Files        1610     1610              
  Lines       55045    55078      +33     
  Branches     6482     6488       +6     
==========================================
+ Hits        42482    42493      +11     
- Misses      12563    12585      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[denysbutenko]

On nightly HA VM (Failover Disabled).

When I change the address in IP Address (This Controller)*, the Test Changes button appears, and I press it. A few moments later, I saw the sign-in page and log in as usual. There were no popups or test changes section present.

When I change two fields IP Address (This Controller)* and IP Address (TrueNAS Controller 2)* it applies without testing changes and connectivity with a system is lost.

[AlexKarpov98]

@denysbutenko - for me it seems like a middleware issue. (only for HA system, Vladimir Vinogradenko approved)

Since after test changes we are just locked and no way back.
It only worked fine when i updated all the IP fields to be 1.1.1.1
And then I’ve seen TEST CHANGES as well and IP’s were rolled back and I showed up a message (Network Reconnection Issue)

Vladimir Vinogradenko 👇 confirmed it as well (but it's only an issue for HA system and specific cases @denysbutenko described)
Hi, thank you for this information, we’ll fix it
Looks like a middleware issue, yes

I tested with non HA system - and it works fine there. There we can only set one IP Address
See non HA system in action ⬇️

Screen.Recording.2024-08-06.at.14.19.42.mov

[denysbutenko]

Looks good

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.