Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-130226 / 24.10 / Improves App installation, update, deletion #10394

Merged
merged 36 commits into from
Aug 7, 2024
Merged

NAS-130226 / 24.10 / Improves App installation, update, deletion #10394

merged 36 commits into from
Aug 7, 2024

Conversation

RehanY147
Copy link
Contributor

Changes:

Changes interfaces and improves API calls for app installation, update and deletion

Testing:

Test general apps functionality. App installation, editing, upgrade should work. Also test rollback function.

Downstream

Affects Reasoning
Documentation

@RehanY147
NAS-130055: Removes roles for kubernetes
dd8cb28
@RehanY147
NAS-130055: Removes roles limitations on app-details-header
9892135
@RehanY147
NAS-130055: Removed roles from app-settings
fcda02b
@RehanY147
NAS-130055: Removes kubernetes service start
175417f
@RehanY147
NAS-130055: Updates KubernetesSettingsComponent to ContainerSettingsC…
836abbc 
…omponent
@RehanY147
NAS-130055: Remove unused translation strings
84597bc
@RehanY147
NAS-130055: Adds DockerService and related interfaces
2317e78
@RehanY147
NAS-130055: Converts KubernetesSettingsComponent to `DockerStatusCo…
e940aaf 
…mponent`

- Adds new `DockerStore` service
- Uses `DockerStore` to replace `KubernetesStore` in `InstalledAppsComponent`
@RehanY147
NAS-130055: Updates docker-status-component folder name
18ca9bd
@RehanY147
NAS-130055: Removes use of KubernetesStore and kubernetes api calls
fdf2e38
@RehanY147
NAS-130055: Removed non-required settings page
f549d7b
@RehanY147
NAS-130055: PR fixes
75c8456
@RehanY147
NAS-130055: Fixed tests
a36f6c6
@RehanY147
Merge branch 'master' into NAS-130055
0670a06
@RehanY147
NAS-130055: Fixed method call
da1d0e0
@RehanY147
NAS-130055: Fix sync catalog call
a0c5565
@RehanY147
NAS-130055: Change catalog.get_item_details to `catalog.get_app_det…
5fc91b8 
…ails`
@RehanY147
NAS-130055: Remove catalog API calls
835a750
@RehanY147
NAS-130055: Remove docker images routes for now
3e14cf1
@RehanY147
NAS-130055: Add manage-catalog component
f5e65c2
@RehanY147
Merge branch 'master' into NAS-130055-pt2
1a93bc2
@RehanY147
Merge branch 'master' into NAS-130055-pt2
c173622
@RehanY147
Merge branch 'master' into NAS-130055-pt2
f7e2d86
@RehanY147
NAS-130055: Remove container images related code
4af3ca4
@RehanY147
NAS-130055: Fix get-app-details call
cf53b21
@RehanY147
NAS-130055: Fixed method call
ce04938
@RehanY147
NAS-130226: Fix App create and update calls
74c497c
@RehanY147
NAS-130226: Fixes app-start and app-stop logic and fix `chart_metadat…
68474aa 
…a` name to just `metadata`
@RehanY147
NAS-130226: Removes chart.release API calls and improves interfaces…
904d004 
… for apps
@RehanY147 RehanY147 requested a review from a team as a code owner August 3, 2024 03:26
@RehanY147 RehanY147 requested review from bvasilenko and removed request for a team August 3, 2024 03:26
@bugclerk bugclerk changed the title Improves App installation, update, deletion NAS-130226 / 24.10 / Improves App installation, update, deletion Aug 3, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Aug 3, 2024

Jira URL: https://ixsystems.atlassian.net/browse/NAS-130226

@RehanY147 RehanY147 marked this pull request as draft August 3, 2024 03:27
@RehanY147 RehanY147 removed the request for review from bvasilenko August 3, 2024 03:27
@denysbutenko denysbutenko mentioned this pull request Aug 3, 2024
Merged
@undsoft undsoft self-requested a review August 5, 2024 16:13
undsoft
undsoft requested changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Tried to install plex on stable train. The installation form seems to have an infinite loop on it, because my browser tab freezes.
  2. Call to app.similar fails with an error.

@undsoft undsoft marked this pull request as ready for review August 7, 2024 07:48
undsoft
undsoft approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to install an app, albeit slowly.

@undsoft undsoft enabled auto-merge (squash) August 7, 2024 07:49
@codecov Codecov
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 46.23656% with 50 lines in your changes missing coverage. Please review.

Project coverage is 76.87%. Comparing base (cb2ede2) to head (5cd3b57).
Report is 4 commits behind head on master.

Files Patch % Lines
...rc/app/pages/apps/services/applications.service.ts 20.00% 20 Missing ⚠️
...pps/app-bulk-upgrade/app-bulk-upgrade.component.ts 0.00% 8 Missing ⚠️
...ponents/installed-apps/installed-apps.component.ts 46.66% 8 Missing ⚠️
...p-containers-card/app-containers-card.component.ts 25.00% 3 Missing ⚠️
...-apps/app-status-cell/app-status-cell.component.ts 0.00% 2 Missing ⚠️
src/app/pages/apps/utils/get-app-status.ts 80.00% 2 Missing ⚠️
...ges/dashboard/services/widget-resources.service.ts 0.00% 2 Missing ⚠️
...app-details-header/app-details-header.component.ts 0.00% 1 Missing ⚠️
...ents/available-apps/app-card/app-card.component.ts 0.00% 1 Missing ⚠️
.../components/chart-wizard/chart-wizard.component.ts 75.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #10394      +/-   ##
==========================================
- Coverage   77.17%   76.87%   -0.30%     
==========================================
  Files        1610     1609       -1     
  Lines       55043    54974      -69     
  Branches     6481     6479       -2     
==========================================
- Hits        42480    42263     -217     
- Misses      12563    12711     +148

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft disabled auto-merge August 7, 2024 09:22
@undsoft undsoft merged commit ab89ebc into master Aug 7, 2024
8 of 9 checks passed
@undsoft undsoft deleted the NAS-130226 branch August 7, 2024 09:22
@bugclerk
Copy link
Contributor

bugclerk commented Aug 7, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@undsoft undsoft undsoft approved these changes

Assignees
No one assigned
Labels
no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RehanY147 @bugclerk @undsoft