Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX] log into truefoundry only when tfy connection is required #399

Merged
merged 1 commit into from
Oct 30, 2024
Merged

[HOTFIX] log into truefoundry only when tfy connection is required #399

merged 1 commit into from
Oct 30, 2024

Conversation

mnvsk97
Copy link
Contributor

@mnvsk97 mnvsk97 commented Oct 30, 2024 •
edited by chiragjn
Loading

  • Remove constant TRUEFOUNDRY_CLIENT that creates a Truefoundry connection on Bootstrap.
  • Log into Truefoundry only when Truefoundry resources are being accessed.

Fixes #382

@mnvsk97 mnvsk97 changed the title fix: log into truefoundry only when tfy connection is required [HOTFIX] log into truefoundry only when tfy connection is required Oct 30, 2024
Blakeinstein
Blakeinstein approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@Blakeinstein Blakeinstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm can we disable truefoundry loader being registered in the loader registry? all registered loaders are sent to frontend and tfy loader wouldn't work without a.client.

@mnvsk97 mnvsk97 merged commit 97fb065 into truefoundry:main Oct 30, 2024
1 check passed
@mnvsk97
Copy link
Contributor Author

mnvsk97 commented Oct 30, 2024

lgtm can we disable truefoundry loader being registered in the loader registry? all registered loaders are sent to frontend and tfy loader wouldn't work without a.client.

https://github.com/truefoundry/cognita/blob/main/backend/modules/dataloaders/__init__.py#L9

Already handled here ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blakeinstein Blakeinstein Blakeinstein approved these changes

@chiragjn chiragjn chiragjn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to finish the docker compose deployment without using TFY_API_KEY
3 participants
@mnvsk97 @chiragjn @Blakeinstein