Skip to content

Commit

Permalink
[ESLint] Consistently treat optional chaining as regular chaining (fa…
Browse files Browse the repository at this point in the history 
…cebook#19273)

* Revert "Fix ExhaustiveDeps ESLint rule throwing with optional chaining (facebook#19260)"

This reverts commit 0f84b0f.

* Re-add a test from facebook#19260

* Remove all code for optional chaining support

* Consistently treat optional chaining as regular chaining

This is not ideal because our suggestions use normal chaining. But it gets rid of all current edge cases.

* Add more tests

* More consistency in treating normal and optional expressions

* Add regression tests for every occurrence of Optional*
  • Loading branch information
@gaearon @trueadm
gaearon authored and trueadm committed Jul 8, 2020
1 parent 8c7e627 commit 2f7b2b8
Show file tree
Hide file tree
Showing 2 changed files with 396 additions and 43 deletions.
Loading

0 comments on commit 2f7b2b8

Please sign in to comment.