-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
android keyboard fix #79
Conversation
@Leoz83 can you do this fix in |
@MarkCarver keyCode I think knowing that it should be ok to do this change. |
@truckingsim, I honestly cannot remember for the life of me why I had put this in. There was a reason. However, after doing a bit of research and lack of git blaming to try and figure out why, I say it's fine to go ahead and remove. FWIW, as a temporary measure users can override this default option with their own to remove it. |
@MarkCarver I'm pretty sure I added it when I first wrote this when it was a single file and you just copied it over. I think I got it from bootstrap-select when I first made this (I know I added the idea of ignored keys because of something in bootstrap-select). |
This reverts commit f967ddd.
Sorry for the confusion 😅 |
This reverts commit f967ddd.
for real, this time
@truckingsim, could you enable https://help.github.com/articles/configuring-pull-request-merge-squashing/ I'd like to squash merge these commits. |
@MarkCarver it should be enabled already. I'm getting the option for it when I click merge, are you not? |
@truckingsim, no... must be my level of permissions or something. That's fine, PR looks good to me. Go ahead. |
No description provided.