Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android keyboard fix #79

Merged
merged 6 commits into from
Jun 24, 2016
Merged

android keyboard fix #79

merged 6 commits into from
Jun 24, 2016

Conversation

pizzolante
Copy link
Contributor

No description provided.

@truckingsim
Copy link
Owner

@Leoz83 can you do this fix in src/js/ajaxSelectPicker.defaults.js. dist/ files are generated by a build script and your change will be overwritten as is.

@truckingsim
Copy link
Owner

@MarkCarver keyCode 229 fires on a dead key keydown. A dead key would be like the ´ above the e in déjà-vu. See this stackoverflow post for more info.

I think knowing that it should be ok to do this change.

@markhalliwell
Copy link
Contributor

@truckingsim, I honestly cannot remember for the life of me why I had put this in. There was a reason. However, after doing a bit of research and lack of git blaming to try and figure out why, I say it's fine to go ahead and remove.

FWIW, as a temporary measure users can override this default option with their own to remove it.

@truckingsim
Copy link
Owner

@MarkCarver I'm pretty sure I added it when I first wrote this when it was a single file and you just copied it over. I think I got it from bootstrap-select when I first made this (I know I added the idea of ignored keys because of something in bootstrap-select).

@markhalliwell
Copy link
Contributor

@pizzolante
Copy link
Contributor Author

Sorry for the confusion 😅

@markhalliwell
Copy link
Contributor

@truckingsim, could you enable https://help.github.com/articles/configuring-pull-request-merge-squashing/

I'd like to squash merge these commits.

@truckingsim
Copy link
Owner

@MarkCarver it should be enabled already. I'm getting the option for it when I click merge, are you not?

@markhalliwell
Copy link
Contributor

@truckingsim, no... must be my level of permissions or something. That's fine, PR looks good to me. Go ahead.

@truckingsim truckingsim merged commit f9718c5 into truckingsim:master Jun 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants