Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selected text format #124

Closed
wants to merge 8 commits into from
Closed

Fix selected text format #124

wants to merge 8 commits into from

Conversation

bercut497
Copy link
Contributor

@bercut497 bercut497 commented Jun 22, 2017

Description (required)

if select element does not have title attribute
selectedTextFormat option will never be restored.

Issues

fix issue #22

@truckingsim
Copy link
Owner

Please don't commit compiled files. Can you resubmit this without the compiled files?

prepare clean branch
This reverts commit fbab292.
@bercut497
Copy link
Contributor Author

done

@truckingsim
Copy link
Owner

truckingsim commented Jun 26, 2017

@bercut497 so I added a select that does what you posted to our example page that looks like your select in #112 that commit is: 7f28ef0.

You can run that example by pulling the latest master, cd into the example directory, run npm install and then npm start. That html will be served at localhost:8080.
It will be the last select on the page titled Add option after init Ajax-Bootstrap-Select.

I ran your code on that example and it doesn't seem to fix it. I'm still seeing emptyTitle even though its setup like you example in #112. Any idea why? Based off of what you said, this PR should fix it, but not seeing it fixed.

@bercut497
Copy link
Contributor Author

my bad.
i test not all.
it happen when flag preserveSelected is true and option add after init
search string === '' and cache[''] === []
may be it can help : try to update cache for queryString key on refresh. (get new option array from $element and put into cache ) need test. you can get some regression.

@bercut497
Copy link
Contributor Author

i will amend this mistake in commit.

@bercut497 bercut497 closed this Jun 26, 2017
@bercut497 bercut497 reopened this Jun 26, 2017
@truckingsim
Copy link
Owner

@bercut497 just updated the example script one more time to match the conditions correctly and this does indeed seem to fix the problem.

@truckingsim
Copy link
Owner

Did a quick change locally and then merged and squashed this locally. It didn't get picked up by github, but it is merged.

@truckingsim
Copy link
Owner

@bercut497 merge commit: e5f075f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants