Solution by Anosov Andrey #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disturm
requested changes
Mar 28, 2018
index.html
Outdated
| } | ||
| else { | ||
| context.scale(1 / 3, 1 / 3); // Уменьшаем масштаб в 3 раза | ||
| drawLine(count - 1, length); context.rotate(60 * deg); |
There was a problem hiding this comment.
несколько инструкций в одной строке - плохой стиль
index.html
Outdated
| var fill = 'transparent'; | ||
| var length = Math.sqrt(Math.pow((points[0].x - points[1].x), 2) + Math.pow((points[0].y - points[1].y), 2)); | ||
| function drawLine(count, length) { | ||
| context.save(); // Сохраняем текущую трансформацию |
There was a problem hiding this comment.
код должен быть понятен без комментариев
index.html
Outdated
| var strokes = ["#6cf", "#9cf", "#99f", "#ccf", "#66f", "#3cf", "#ff33cc", "#ff3366", "#33ff66"]; | ||
| var stroke = strokes[rand(strokes.length)]; | ||
| var fill = 'transparent'; | ||
| var length = Math.sqrt(Math.pow((points[0].x - points[1].x), 2) + Math.pow((points[0].y - points[1].y), 2)); |
There was a problem hiding this comment.
Math.pow(v, 2) - это медленный способ возведения в квадрат. Тут не критично, но уже пора запомнить и использовать умножение.
index.html
Outdated
|
|
||
|
|
||
| } | ||
| context.save(); context.strokeStyle = stroke; |
There was a problem hiding this comment.
Здесь и ниже тоже не используй несколько команд в одной строке.
Чтобы было видно, что несколько команд относятся к чему-то одному — оставь пустую строчки после предыдущих инструкций и до последующих
doSomething();
doAction1();
doAction2();
doAction3();
doSomething();
disturm
approved these changes
Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.