feature(build): update gradle from 4.0 to 6.3 #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Master merge to develop
Refactor StringUtils.isContains
lxcmyf
reviewed
Sep 24, 2024
| classpath 'com.google.protobuf:protobuf-gradle-plugin:0.8.3' | ||
| classpath "gradle.plugin.com.liferay:gradle-plugins-node:4.3.0" | ||
| classpath 'com.github.jengelman.gradle.plugins:shadow:5.2.0' | ||
| classpath 'com.google.protobuf:protobuf-gradle-plugin:0.8.12' |
There was a problem hiding this comment.
In line 51, this version is 7.1.2 in java-tron.
There was a problem hiding this comment.
which dependency ?
There was a problem hiding this comment.
classpath "gradle.plugin.com.github.johnrengelman:shadow:7.1.2" . This version of Shadow supports Gradle 7.0+ only. So 5.2.0 is available.
There was a problem hiding this comment.
@lxcmyf shadow is not necessary for java-tron. You can try to compile it without shadow.
lxcmyf
reviewed
Sep 24, 2024
| testAnnotationProcessor 'org.projectlombok:lombok:1.18.24' | ||
|
|
||
| implementation group: 'org.jline', name: 'jline', version: '3.25.0' | ||
| implementation group: 'io.github.tronprotocol', name: 'zksnark-java-sdk', version: '1.0.0' |
There was a problem hiding this comment.
It's best to keep these upgraded versions consistent with Java tron.
There was a problem hiding this comment.
The version of grpc、protobuf is same as that used in java-tron. Other dependency is not very important. jline and zksnark-java-sdk is not changed.
lxcmyf
approved these changes
Oct 8, 2024
halibobo1205
approved these changes
Oct 8, 2024
hasti0073
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why are these changes required?
This PR has been tested by:
Follow up
Extra details