Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): correct config path of RPC reflection service #5739

Conversation

tomatoishealthy
Copy link
Contributor

@tomatoishealthy tomatoishealthy commented Mar 1, 2024

What does this PR do?

RPC reflection service can be activated with the config path: node.rpc.reflectionService.

But it has been configured with the wrong path in the config.conf of the framework: node.reflectionService.

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@tomatoishealthy tomatoishealthy changed the title fix(config): correct the config path of the RPC reflection service fix(config): correct config path of RPC reflection service Mar 1, 2024
@tomatoishealthy
Copy link
Contributor Author

tomatoishealthy commented Mar 1, 2024

TODO: sync to tron-deployment

@tomatoishealthy tomatoishealthy merged commit 96afa15 into tronprotocol:release_v4.7.4 Mar 4, 2024
5 checks passed
@halibobo1205 halibobo1205 added this to the GreatVoyage-v4.7.4 milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants