Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): optimize NodeInfoServiceTest for testcase coverage #5333

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

317787106
Copy link
Contributor

What does this PR do?

  • optimize NodeInfoServiceTest to make coverage of testcase more stable

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-commenter
Copy link

Codecov Report

Merging #5333 (0b67b1a) into develop (dcd0ebd) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@              Coverage Diff              @@
##             develop    #5333      +/-   ##
=============================================
+ Coverage      60.79%   60.85%   +0.06%     
- Complexity      9217     9220       +3     
=============================================
  Files            839      839              
  Lines          50031    50031              
  Branches        5575     5575              
=============================================
+ Hits           30417    30448      +31     
+ Misses         17238    17201      -37     
- Partials        2376     2382       +6     

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@317787106 317787106 changed the title feat(test): optimize NodeInfoServiceTest feat(test): optimize NodeInfoServiceTest for testcase coverage Jul 3, 2023
@317787106 317787106 merged commit 7c6c89e into tronprotocol:develop Jul 4, 2023
@halibobo1205 halibobo1205 added this to the GreatVoyage-v4.7.3 milestone Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants