Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(refactor): Credentials.equal method and add unit tests #3898

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

DoctorLai
Copy link
Contributor

What does this PR do?
Cleaner code and add unit test for Credentials.equal method

Why are these changes required?
Cleaner code and add unit tests

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2021

Codecov Report

Merging #3898 (3628b9c) into develop (e5c51ef) will increase coverage by 0.36%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3898      +/-   ##
=============================================
+ Coverage      52.44%   52.80%   +0.36%     
- Complexity      7088     7148      +60     
=============================================
  Files            772      772              
  Lines          43410    43409       -1     
  Branches        4686     4684       -2     
=============================================
+ Hits           22766    22922     +156     
+ Misses         18820    18657     -163     
- Partials        1824     1830       +6     
Impacted Files Coverage Δ
...k/src/main/java/org/tron/keystore/Credentials.java 57.14% <100.00%> (+57.14%) ⬆️
...mon/overlay/discover/table/DistanceComparator.java 80.00% <0.00%> (-20.00%) ⬇️
...rc/main/java/org/tron/core/vm/program/Program.java 60.29% <0.00%> (+0.09%) ⬆️
framework/src/main/java/org/tron/core/Wallet.java 17.02% <0.00%> (+0.22%) ⬆️
...java/org/tron/core/capsule/TransactionCapsule.java 51.69% <0.00%> (+0.24%) ⬆️
.../src/main/java/org/tron/core/db/KhaosDatabase.java 69.69% <0.00%> (+0.60%) ⬆️
.../java/org/tron/common/overlay/server/SyncPool.java 42.05% <0.00%> (+0.93%) ⬆️
.../main/java/org/tron/core/db2/common/TxCacheDB.java 71.60% <0.00%> (+1.23%) ⬆️
...mework/src/main/java/org/tron/core/db/Manager.java 58.68% <0.00%> (+1.61%) ⬆️
...va/org/tron/common/overlay/discover/node/Node.java 72.54% <0.00%> (+1.96%) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5c51ef...3628b9c. Read the comment docs.

@halibobo1205 halibobo1205 changed the title Refactor Credentials.equal method and add unit tests feat(refactor): Credentials.equal method and add unit tests Jun 20, 2023
@halibobo1205 halibobo1205 merged commit f5ab656 into tronprotocol:develop Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants