Skip to content

Commit

Permalink
Remove VL variants for 4FMAPS and 4VNNIW insns.
Browse files Browse the repository at this point in the history
AVX512_4FMAPS and AVX512_4VNNIW insns are marked as having AVX512VL
variants.  That is wrong as SDM doesn't define such instructions. The
patch removes these VL variants.

gas/
	* testsuite/gas/i386/avx512_4fmaps-warn.l: Change xmm to zmm.
	* testsuite/gas/i386/avx512_4fmaps-warn.s: Likewise.
	* testsuite/gas/i386/avx512_4fmaps_vl-intel.d: Delete.
	* testsuite/gas/i386/avx512_4fmaps_vl-warn.l: Likewise.
	* testsuite/gas/i386/avx512_4fmaps_vl-warn.s: Likewise.
	* testsuite/gas/i386/avx512_4fmaps_vl.d: Likewise.
	* testsuite/gas/i386/avx512_4fmaps_vl.s: Likewise.
	* testsuite/gas/i386/avx512_4vnniw_vl-intel.d: Likewise.
	* testsuite/gas/i386/avx512_4vnniw_vl.d: Likewise.
	* testsuite/gas/i386/avx512_4vnniw_vl.s: Likewise.
	* testsuite/gas/i386/i386.exp: Delete _vl tests for 4fmaps an
	4vnniw tests.
	* testsuite/gas/i386/x86-64-avx512_4fmaps_vl-intel.d: Delete.
	* testsuite/gas/i386/x86-64-avx512_4fmaps_vl-warn.l: Likewise.
	* testsuite/gas/i386/x86-64-avx512_4fmaps_vl-warn.s: Likewise.
	* testsuite/gas/i386/x86-64-avx512_4fmaps_vl.d: Likewise.
	* testsuite/gas/i386/x86-64-avx512_4fmaps_vl.s: Likewise.
	* testsuite/gas/i386/x86-64-avx512_4vnniw_vl-intel.d: Likewise.
	* testsuite/gas/i386/x86-64-avx512_4vnniw_vl.d: Likewise.
	* testsuite/gas/i386/x86-64-avx512_4vnniw_vl.s: Likewise.

opcodes/
	* i386-opc.tbl: Remove VL variants for 4FMAPS and 4VNNIW
	insns.
	* i386-tbl.h: Regenerate.
  • Loading branch information
itsimbal committed Jan 11, 2018
1 parent 710d7ea commit 888a89d
Show file tree
Hide file tree
Showing 23 changed files with 41 additions and 1,202 deletions.
20 changes: 20 additions & 0 deletions gas/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,23 @@
2018-01-11 Igor Tsimbalist <[email protected]>

* testsuite/i386/avx512_4fmaps_vl-warn.l: Likewise.
* testsuite/i386/avx512_4fmaps_vl-warn.s: Likewise.
* testsuite/i386/avx512_4fmaps_vl.d: Likewise.
* testsuite/i386/avx512_4fmaps_vl.s: Likewise.
* testsuite/i386/avx512_4vnniw_vl-intel.d: Likewise.
* testsuite/i386/avx512_4vnniw_vl.d: Likewise.
* testsuite/i386/avx512_4vnniw_vl.s: Likewise.
* testsuite/i386/i386.exp: Removed _vl tests for 4fmaps an 4vnniw
tests.
* testsuite/i386/x86-64-avx512_4fmaps_vl-intel.d: Removed.
* testsuite/i386/x86-64-avx512_4fmaps_vl-warn.l: Likewise.
* testsuite/i386/x86-64-avx512_4fmaps_vl-warn.s: Likewise.
* testsuite/i386/x86-64-avx512_4fmaps_vl.d: Likewise.
* testsuite/i386/x86-64-avx512_4fmaps_vl.s: Likewise.
* testsuite/i386/x86-64-avx512_4vnniw_vl-intel.d: Likewise.
* testsuite/i386/x86-64-avx512_4vnniw_vl.d: Likewise.
* testsuite/i386/x86-64-avx512_4vnniw_vl.s: Likewise.

2018-01-11 Alan Modra <[email protected]>

* config/tc-arm.c (aeabi_set_public_attributes): Avoid false
Expand Down
12 changes: 6 additions & 6 deletions gas/testsuite/gas/i386/avx512_4fmaps-warn.l
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
.*: Assembler messages:
.*:5: Warning: the second source register `%xmm1' implicitly denotes `%xmm0' to `%xmm3' source group in `v4fmaddps'
.*:6: Warning: the second source register `%xmm2' implicitly denotes `%xmm0' to `%xmm3' source group in `v4fmaddps'
.*:7: Warning: the second source register `%xmm3' implicitly denotes `%xmm0' to `%xmm3' source group in `v4fmaddps'
.*:10: Warning: the second source register `%xmm1' implicitly denotes `%xmm0' to `%xmm3' source group in `v4fnmaddps'
.*:11: Warning: the second source register `%xmm2' implicitly denotes `%xmm0' to `%xmm3' source group in `v4fnmaddps'
.*:12: Warning: the second source register `%xmm3' implicitly denotes `%xmm0' to `%xmm3' source group in `v4fnmaddps'
.*:5: Warning: the second source register `%zmm1' implicitly denotes `%zmm0' to `%zmm3' source group in `v4fmaddps'
.*:6: Warning: the second source register `%zmm2' implicitly denotes `%zmm0' to `%zmm3' source group in `v4fmaddps'
.*:7: Warning: the second source register `%zmm3' implicitly denotes `%zmm0' to `%zmm3' source group in `v4fmaddps'
.*:10: Warning: the second source register `%zmm1' implicitly denotes `%zmm0' to `%zmm3' source group in `v4fnmaddps'
.*:11: Warning: the second source register `%zmm2' implicitly denotes `%zmm0' to `%zmm3' source group in `v4fnmaddps'
.*:12: Warning: the second source register `%zmm3' implicitly denotes `%zmm0' to `%zmm3' source group in `v4fnmaddps'
.*:15: Warning: the second source register `%xmm1' implicitly denotes `%xmm0' to `%xmm3' source group in `v4fmaddss'
.*:16: Warning: the second source register `%xmm2' implicitly denotes `%xmm0' to `%xmm3' source group in `v4fmaddss'
.*:17: Warning: the second source register `%xmm3' implicitly denotes `%xmm0' to `%xmm3' source group in `v4fmaddss'
Expand Down
20 changes: 10 additions & 10 deletions gas/testsuite/gas/i386/avx512_4fmaps-warn.s
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
# Check warnings for invalid usage of register group

.text
v4fmaddps (%eax), %xmm0, %xmm6
v4fmaddps (%eax), %xmm1, %xmm6
v4fmaddps (%eax), %xmm2, %xmm6
v4fmaddps (%eax), %xmm3, %xmm6
v4fmaddps (%eax), %xmm4, %xmm6
v4fnmaddps (%eax), %xmm0, %xmm6
v4fnmaddps (%eax), %xmm1, %xmm6
v4fnmaddps (%eax), %xmm2, %xmm6
v4fnmaddps (%eax), %xmm3, %xmm6
v4fnmaddps (%eax), %xmm4, %xmm6
v4fmaddps (%eax), %zmm0, %zmm6
v4fmaddps (%eax), %zmm1, %zmm6
v4fmaddps (%eax), %zmm2, %zmm6
v4fmaddps (%eax), %zmm3, %zmm6
v4fmaddps (%eax), %zmm4, %zmm6
v4fnmaddps (%eax), %zmm0, %zmm6
v4fnmaddps (%eax), %zmm1, %zmm6
v4fnmaddps (%eax), %zmm2, %zmm6
v4fnmaddps (%eax), %zmm3, %zmm6
v4fnmaddps (%eax), %zmm4, %zmm6
v4fmaddss (%eax), %xmm0, %xmm6
v4fmaddss (%eax), %xmm1, %xmm6
v4fmaddss (%eax), %xmm2, %xmm6
Expand Down
79 changes: 0 additions & 79 deletions gas/testsuite/gas/i386/avx512_4fmaps_vl-intel.d

This file was deleted.

13 changes: 0 additions & 13 deletions gas/testsuite/gas/i386/avx512_4fmaps_vl-warn.l

This file was deleted.

23 changes: 0 additions & 23 deletions gas/testsuite/gas/i386/avx512_4fmaps_vl-warn.s

This file was deleted.

79 changes: 0 additions & 79 deletions gas/testsuite/gas/i386/avx512_4fmaps_vl.d

This file was deleted.

Loading

0 comments on commit 888a89d

Please sign in to comment.