Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Same log entries #151

Closed
alexeys85 opened this issue Nov 2, 2020 · 4 comments
Closed

Same log entries #151

alexeys85 opened this issue Nov 2, 2020 · 4 comments
Milestone
v2.5

Comments

@alexeys85
Copy link
Contributor

Seems like copy-paste typo, but anyway:

smcroute/src/inet.c

Line 104 in 7c8fdf0

smclog(LOG_ERR, "Failed joining group %s: %s", MC_ALL_SNOOPERS);

and

smcroute/src/inet.c

Line 112 in 7c8fdf0

smclog(LOG_ERR, "Failed joining group %s: %s", MC_ALL_SNOOPERS);

Has to be MC_ALL_ROUTERS in second case.

P.S. For what purpose it is necessary to join MC_ALL_SNOOPERS group as well?
@troglobit
Copy link
Owner

Yup, you're right.

The MC_ALL_SNOOPERS group is used by the mrdisc code, RFC4286.

@alexeys85
Copy link
Contributor Author

smcroute uses MC_ALL_SNOOPERS to send announces, but without any processing of the received announces?

@troglobit
Copy link
Owner

Ah, of course, my bad. True, that's not needed in the role SMCRoute has on the network. Thanks for pointing this out!

troglobit added a commit that referenced this issue Jul 27, 2021
@troglobit
inet: Fix missing strerror() arg, and copy-paste problem
178b19a 
One pointed out by Coverity Scan, the other as mentioned in issue #151.

Note: we should probably remove that piece of the code, ref #151, but
      first a unit test to verify the mrdisc functionality! :)

Signed-off-by: Joachim Wiberg <[email protected]>
@troglobit troglobit added this to the v2.5 milestone Jul 27, 2021
@troglobit
Copy link
Owner

Had a chance to look into this now, finally. Turns out we support IGMP_MRDISC_SOLICIT, which is why we join both snoopers and routers. At Westermo our switches (snooping devices) send solicitations on the snoopers address.

So everything as expected. Copy-paste bug fixed earlier, in 178b19a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.5
Development

No branches or pull requests
2 participants
@troglobit @alexeys85