Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch for using '/' symbol instead of 'masklen' word #12

Closed
alexpro opened this issue Dec 5, 2011 · 1 comment
Closed

patch for using '/' symbol instead of 'masklen' word #12

alexpro opened this issue Dec 5, 2011 · 1 comment

Comments

@alexpro
Copy link

alexpro commented Dec 5, 2011

Greetings!
My English is not very good, excuse me if I said something wrong.

I think that syntax [ip_addr] masklen [masklen] in configuration file is not very convenient. In my opinion, much better [ip_addr]/[masklen] syntax. I just created a patch for config.c which allows to use any of both of syntaxes: [ip_addr] masklen [masklen] or [ip_addr]/[masklen].
If it is interesting to you, then patch can be downloaded from here: http://gentoo.homelan.lg.ua/distrib/config-use_slash_masklen.patch

With best regards, Alexey Prokopchuk (AP8686-RIPE).
@troglobit
Copy link
Owner

Sorry for the lack of response on this issue! I've been a bit preoccupied with other things the last year.

Very good of you to step up and add this functionality. I'll rework it a bit, to reduce code duplication and fix coding style, then commit it to master before the next release.

Thanks!

troglobit added a commit that referenced this issue Aug 18, 2012
@troglobit
pimd.conf: Support for /PREFIXLEN instead of masklen PREFIXLEN syntax
6353607 
o Coding style fixes
o Change configfilename to config_file
o Simplify config.c:next_word()
o Add line number to syntax/parse errors
o Add support for /PREFIXLEN, alternative to 'masklen <PREFIXLEN>'
  Based on patch from Alexey Prokopchuk, see issue #12
@swiergot swiergot mentioned this issue Mar 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@troglobit @alexpro