Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pimd (git version r7655b67) fails to build from source on Debian testing #11

Closed
Corin-EU opened this issue Sep 24, 2011 · 2 comments
Closed

pimd (git version r7655b67) fails to build from source on Debian testing #11

Corin-EU opened this issue Sep 24, 2011 · 2 comments

Comments

@Corin-EU
Copy link

Current pimd version r7655b67 in the git repository fails to compile for two reasons.

In the makefile, no include path is specified which is necessary for the source tree include directory containing the required header file netinet/pim.h

In the makefile, CFLAGS includes -Werror which means that with gcc-4.6, compilation of any file containing an unused variable will terminate with the unused variable error.

Furthermore the first declaration of CFLAGS in the makefile is CFLAGS =, rather than CFLAGS += which means that the makefile ignores any CFLAG enviromental variable set with the string

"-I <path_to_src>/include -Wno-error=unused-but-set-variable"

in order to correct the deficiences of the makefile.
bobek added a commit that referenced this issue Oct 22, 2011
@bobek @troglobit
Fix Debian issue #634393 and GitHub issues #10, #11: Fails to build f…
b6e7f8c 
…rom source

main.c:
        Removed unused variables in main.c, add friendly warning if
        call to system() fails.
vif.c:
        src is not used in start_vif()
route.c:
        Added __attribute__((unused)) to several (yet?) unused constructs
        to instruct GCC to not warn.

pim_proto.c:
        Dito.
@troglobit
Copy link
Owner

The Makefile is constructed to work on both GNU/Linux and *BSD systems. There is an include statement to include the file config.mk which does indeed setup the include path "-Iinclude" using the INCLUDES variable. Please see that file for more information on how to configure pimd before building.

However, I agree with you that the use of CFLAGS= rather than CFLAGS+= is rather clumsy. This has been kept for historical reasons, the intent was for the user to employ USERCOMPILE for that same purpose instead. That is what I use when cross-compiling pimd for our embedded systems at work. It should be sufficient for your purposes as well I think.

I've just closed issue #10 after having audited and added some changes of my own to Antonin's original patch. Please try that out and comment.

@troglobit
Copy link
Owner

OK, I've changed the behavior of CFLAGS in the just tagged v2.1.8. I believe that was the last of the problems detailed in this, and previous, issue #10. Thank you for the report!

@swiergot swiergot mentioned this issue Mar 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@troglobit @Corin-EU