add the ability to add intervals to the timer picker

[OmerToledo]

No description provided.

[OmerToledo]

@troberts-28
i still have 2 issues
take a look at the video :)

1. it doesnt reach the 60
2. when i scroll sometimes there is a weird jumping in the ui
   any idea what causing
   this bugs ?

btw, im not sure its happing when infinite scroll is disabled

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-16.at.16.07.09.mp4

[troberts-28]

Hey @OmerToledo 👋

Thanks for the PR! The issues are related to this: #33.

Essentially, the infinite scroll works by auto-scrolling further up the list when you near the start/end of the list. There is a very slight flicker when it does that and I haven't been able to figure out a way of avoiding that completely. To avoid the flicker being noticeable to the user, the numbers are repeated a given number of times (so it does not have to auto-scroll as often). You'll find props on the TimerPicker component to modify the number of repetitions for each picker. The right approach would be to modify those defaults based on the interval (i.e. the length of the list).

Does that make sense?

[troberts-28]

Hey @OmerToledo

Sorry, have really slept on this! Will take a look at this this week and get it merged.

[troberts-28]

This has now been merged into v2.0.0. Thanks @OmerToledo!

Just a minor pointer for future work - use more descriptive commit messages to make it easier for a reviewer to understand your work.

[OmerToledo]

hi no problem!
thanks for the engagement :)

[OmerToledo]

also, i saw that because of the facts that you didnt merged my changed directly from here, I'm not a contributor which can be nice, but of course its up to your decision :)