Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test 1.11 #520

Closed
wants to merge 9 commits into from
Closed

Test 1.11 #520

wants to merge 9 commits into from

Conversation

svchb
Copy link
Collaborator

@svchb svchb commented May 8, 2024

Not to be merged.

Just to give an idea if 1.11 will cause any issues.

@svchb svchb marked this pull request as draft May 8, 2024 07:36
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.37%. Comparing base (2ccc340) to head (3ea2da6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #520   +/-   ##
=======================================
  Coverage   69.37%   69.37%           
=======================================
  Files          85       85           
  Lines        5124     5124           
=======================================
  Hits         3555     3555           
  Misses       1569     1569           
Flag Coverage Δ
unit 69.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svchb svchb changed the title test beta Test 1.11 May 8, 2024
@svchb
Copy link
Collaborator Author

svchb commented May 8, 2024

WIth beta1:

  • fails oscillating_drop_2d.jl
  • and the related validation case

There is a performance regression in beta1 which also effects us which causes about 30% slower execution.

@svchb svchb closed this May 30, 2024
@svchb svchb reopened this May 30, 2024
@svchb
Copy link
Collaborator Author

svchb commented May 30, 2024

Beta-2:

  • dam_break validation fails
  • oscillating drop diverges

There is a performance regression in beta1 and 2 which also effects us which causes about 30% slower execution.

@svchb svchb closed this Jun 27, 2024
@svchb svchb reopened this Jun 27, 2024
@svchb
Copy link
Collaborator Author

svchb commented Jun 27, 2024

Test Name RC 1 (s) 1.10 (s) Percentage Difference (%)
All Tests 2225 1757.2 -21.02
Examples 1734.4 1393.8 -19.64
Fluid 1208 1001.1 -17.11
fluid/oscillating_drop_2d.jl 53.6 (crashed) 74.1 38.25
fluid/hydrostatic_water_column_2d.jl 19.2 15.6 -18.75
fluid/hydrostatic_water_column_2d.jl with source term damping 15.2 12.7 -16.45
fluid/hydrostatic_water_column_2d.jl with SummationDensity 19.0 15.3 -19.47
fluid/hydrostatic_water_column_3d.jl 27.1 22.3 -17.71
fluid/hydrostatic_water_column_3d.jl with SummationDensity 32.8 27.1 -17.38
fluid/hydrostatic_water_column_edac_2d.jl 16.3 13.0 -20.25
fluid/accelerated_tank_2d.jl 15.8 13.1 -17.09
fluid/dam_break_2d.jl 32.1 23.7 -26.17
fluid/dam_break_2d.jl with KernelAbstractions.jl 25.3 18.4 -27.27
fluid/dam_break_3d.jl 21.1 17.2 -18.48
fluid/falling_water_column_2d.jl 13.5 11.0 -18.52
fluid/periodic_channel_2d.jl 21.4 18.5 -13.55
fluid/pipe_flow_2d.jl 53.6 52.7 -1.68
fluid/dam_break_2d_surface_tension.jl 83.9 71.3 -15.02
fluid/sphere_surface_tension_2d.jl 10.6 7.6 -28.30
fluid/sphere_surface_tension_3d.jl 49.6 43.4 -12.50
fluid/falling_water_spheres_2d.jl 75.9 61.6 -18.84
fluid/falling_water_spheres_3d.jl 113.3 92.7 -18.19
fluid/sphere_surface_tension_wall_2d.jl 152 132.1 -13.09
fluid/moving_wall_2d.jl 15.4 12.5 -18.83
dam_break_2d.jl with corrections 340 244 -28.24
continuity_reinit 16.1 13.2 -18.01
gradient_continuity_correction 31.6 20.4 -35.44
gradient_summation_correction 32.9 22 -33.13
no_correction 17.8 13.8 -22.47
shepard_kernel_correction 24 18.7 -22.08
blended_gradient_continuity_correction 30.4 20.1 -33.88
mixed_kernel_gradient_summation_correction 42.7 29.6 -30.68
akinci_free_surf_correction 17.9 14.6 -18.44
kernel_correction_summation_correction 29.4 21 -28.57
mixed_kernel_gradient_continuity_correction 38.4 28.9 -24.74
kernel_correction_continuity_correction 26.4 19.3 -26.89
blended_gradient_summation_correction 31.6 21.7 -31.33
Solid 21.2 12.7 -40.09
solid/oscillating_beam_2d.jl 21.2 12.7 -40.09
FSI 431.6 317.4 -26.48
fsi/falling_water_column_2d.jl 28.5 19.4 -31.93
fsi/dam_break_plate_2d.jl 59.8 47.9 -19.90
fsi/dam_break_gate_2d.jl 238.2 164.3 -31.01
fsi/falling_spheres_2d.jl 104.9 85.6 -18.40
N-Body 27.5 26.7 -2.91
n_body/n_body_solar_system.jl 5.8 4.6 -20.69
n_body/n_body_benchmark_trixi.jl 13.9 15.0 7.91
n_body/n_body_benchmark_reference.jl 3.9 3.3 -15.38
n_body/n_body_benchmark_reference_faster.jl 3.8 3.7 -2.63
Postprocessing 46.1 35.9 -22.13
postprocessing/interpolation_plane.jl 29.3 23.4 -20.14
postprocessing/interpolation_point_line.jl 2.6 2.1 -19.23
postprocessing/postprocessing.jl 14.0 10.2 -27.14
DEM 10.7 8.9 -16.82
dem/rectangular_tank_2d.jl 10.6 8.9 -16.04
Validation 479.8 354.4 -26.13
general 57.6 44.1 -23.44
oscillating_beam_2d 106.6 63.1 -40.80
dam_break_2d 315.4 247 -21.69

@efaulhaber
Copy link
Member

Do you know where these regressions come from exactly?

@svchb
Copy link
Collaborator Author

svchb commented Jun 27, 2024

I did not look into this any further than the CI run times. 1.11 will probably be released in August.

@svchb
Copy link
Collaborator Author

svchb commented Aug 6, 2024

Test Category Passed Failed Total 1.11 RC2 (s) 1.10.4
All Tests 149 2 151 2391.6 1841.6
Examples 128 128 1958.4 1548.6
Fluid 101 101 1450.6 1172.4
fluid/oscillating_drop_2d.jl 4 4 44.3 29.7
fluid/hydrostatic_water_column_2d.jl 3 3 18.9 15.3
fluid/hydrostatic_water_column_2d.jl with source term damping 3 3 14.4 12.1
fluid/hydrostatic_water_column_2d.jl with SummationDensity 3 3 17.4 14.3
fluid/hydrostatic_water_column_3d.jl 3 3 25.4 21.6
fluid/hydrostatic_water_column_3d.jl with SummationDensity 3 3 28.8 24.0
fluid/hydrostatic_water_column_edac_2d.jl 3 3 15.1 12.4
fluid/accelerated_tank_2d.jl 3 3 15.1 12.5
fluid/dam_break_2d.jl 3 3 30.0 21.6
fluid/dam_break_oil_film_2d.jl 3 3 296.2 263.2
fluid/dam_break_2d.jl with KernelAbstractions.jl 3 3 25.0 17.6
fluid/dam_break_3d.jl 3 3 19.5 16.2
fluid/falling_water_column_2d.jl 3 3 12.1 10.5
fluid/periodic_channel_2d.jl 3 3 21.1 18.2
fluid/pipe_flow_2d.jl 3 3 54.5 54.3
fluid/dam_break_2d_surface_tension.jl 3 3 79.0 67.9
fluid/sphere_surface_tension_2d.jl 3 3 9.3 7.1
fluid/sphere_surface_tension_3d.jl 3 3 45.7 39.6
fluid/falling_water_spheres_2d.jl 3 3 76.1 60.8
fluid/falling_water_spheres_3d.jl 3 3 124.7 100.2
fluid/sphere_surface_tension_wall_2d.jl 1 1 145.1 124.9
fluid/moving_wall_2d.jl 3 3 15.7 11.9
dam_break_2d.jl with corrections 36 36 316.0 215.3
continuity_reinit 3 3 15.5 12.9
gradient_continuity_correction 3 3 27.8 18.0
gradient_summation_correction 3 3 29.8 19.8
no_correction 3 3 15.9 12.5
shepard_kernel_correction 3 3 22.6 16.7
blended_gradient_continuity_correction 3 3 27.8 18.1
mixed_kernel_gradient_summation_correction 3 3 41.6 24.9
akinci_free_surf_correction 3 3 16.3 13.2
kernel_correction_summation_correction 3 3 25.6 18.1
mixed_kernel_gradient_continuity_correction 3 3 39.8 23.9
kernel_correction_continuity_correction 3 3 24.1 17.1
blended_gradient_summation_correction 3 3 28.3 19.5
Solid 3 3 19.5 10.5
solid/oscillating_beam_2d.jl 3 3 19.5 10.5
FSI 12 12 402.0 294.2
fsi/falling_water_column_2d.jl 3 3 25.4 17.9
fsi/dam_break_plate_2d.jl 3 3 56.1 43.2
fsi/dam_break_gate_2d.jl 3 3 220.0 151.8
fsi/falling_spheres_2d.jl 3 3 100.3 81.2
N-Body 6 6 27.7 24.9
n_body/n_body_solar_system.jl 3 3 6.0 4.3
n_body/n_body_benchmark_trixi.jl 1 1 13.8 14.0
n_body/n_body_benchmark_reference.jl 1 1 3.9 3.0
n_body/n_body_benchmark_reference_faster.jl 1 1 3.8 3.4
Postprocessing 6 6 58.6 46.5
postprocessing/interpolation_plane.jl 2 2 41.9 34.6
postprocessing/interpolation_point_line.jl 2 2 2.6 2.1
postprocessing/postprocessing.jl 2 2 14.0 9.6
DEM 3 3 10.0 8.3
dem/rectangular_tank_2d.jl 3 3 9.9 8.3
Validation 18 2 20 423.1 284.6
general 4 4 41.8 31.2
oscillating_beam_2d 7 7 85.9 43.5

@svchb
Copy link
Collaborator Author

svchb commented Aug 6, 2024

Performance regression caused by this JuliaLang/julia#55009

@efaulhaber
Copy link
Member

In the issue they said it's probably going to get backported to 1.11.

@svchb svchb closed this Oct 9, 2024
@svchb svchb reopened this Oct 9, 2024
@svchb
Copy link
Collaborator Author

svchb commented Oct 9, 2024

The last times were 1.9 39:52/40:05 1.10 38:05 1.11 46:11/46:52/47:09 at the time of 1.11 release

@svchb svchb closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants