Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new meshes/solvers are stable #742

Merged
merged 8 commits into from
Jul 29, 2021
Merged

new meshes/solvers are stable #742

merged 8 commits into from
Jul 29, 2021

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Jul 27, 2021

I removed the experimental warnings and adapted the README.md accordingly. We should discuss whether the presentation of the main features in the README.md looks good to us in today's Trixi meeting.

Edit: The presentation of the main features is updated as discussed

Closes #542

@ranocha ranocha added the triage To be decided at the next Trixi meeting label Jul 27, 2021
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #742 (7dc7709) into main (bd621f2) will not change coverage.
The diff coverage is n/a.

❗ Current head 7dc7709 differs from pull request most recent head c332c53. Consider uploading reports for the commit c332c53 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #742   +/-   ##
=======================================
  Coverage   93.72%   93.72%           
=======================================
  Files         179      179           
  Lines       17082    17082           
=======================================
  Hits        16010    16010           
  Misses       1072     1072           
Flag Coverage Δ
unittests 93.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
examples/dgmulti_2d/elixir_euler_weakform.jl 100.00% <ø> (ø)
examples/dgmulti_3d/elixir_euler_weakform.jl 100.00% <ø> (ø)
src/callbacks_step/analysis_dgmulti.jl 97.37% <ø> (ø)
src/meshes/dgmulti_meshes.jl 89.29% <ø> (ø)
src/meshes/p4est_mesh.jl 98.39% <ø> (ø)
src/meshes/structured_mesh.jl 90.53% <ø> (ø)
src/meshes/surface_interpolant.jl 100.00% <ø> (ø)
src/meshes/unstructured_mesh.jl 98.23% <ø> (ø)
src/solvers/dgmulti/dg.jl 96.27% <ø> (ø)
src/solvers/dgsem_p4est/containers.jl 92.57% <ø> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d318d5b...c332c53. Read the comment docs.

@ranocha ranocha removed the triage To be decided at the next Trixi meeting label Jul 27, 2021
README.md Outdated Show resolved Hide resolved
docs/src/index.md Outdated Show resolved Hide resolved
src/solvers/dgsem_unstructured/sort_boundary_conditions.jl Outdated Show resolved Hide resolved
@ranocha ranocha enabled auto-merge (squash) July 28, 2021 04:58
@jlchan
Copy link
Contributor

jlchan commented Jul 28, 2021

LGTM now!

Copy link
Member

@efaulhaber efaulhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ranocha ranocha disabled auto-merge July 29, 2021 04:02
@ranocha ranocha merged commit 664fd38 into main Jul 29, 2021
@ranocha ranocha deleted the hr/meshes_are_stable branch July 29, 2021 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate mesh infrastructure after adding structured and unstructured ones
3 participants