Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Cubed Sphere as P4estMesh #689

Merged
merged 13 commits into from
Jul 5, 2021

Conversation

efaulhaber
Copy link
Member

10th point of #584.

@efaulhaber efaulhaber marked this pull request as ready for review June 30, 2021 20:56
@efaulhaber efaulhaber requested a review from sloede June 30, 2021 20:57
@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #689 (bcf9274) into main (3ae92e6) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
+ Coverage   93.63%   93.70%   +0.07%     
==========================================
  Files         171      171              
  Lines       16535    16712     +177     
==========================================
+ Hits        15482    15659     +177     
  Misses       1053     1053              
Flag Coverage Δ
unittests 93.70% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meshes/p4est_mesh.jl 98.39% <100.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ae92e6...bcf9274. Read the comment docs.

Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general! just a few suggestions/questions/remarks from my side, but no blockers

src/meshes/p4est_mesh.jl Show resolved Hide resolved
src/meshes/p4est_mesh.jl Show resolved Hide resolved
src/meshes/p4est_mesh.jl Outdated Show resolved Hide resolved
src/meshes/p4est_mesh.jl Show resolved Hide resolved
src/meshes/p4est_mesh.jl Show resolved Hide resolved
@efaulhaber efaulhaber requested a review from sloede July 4, 2021 16:16
@efaulhaber efaulhaber closed this Jul 4, 2021
@efaulhaber efaulhaber reopened this Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants