Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add free stream preservation tests for non-conforming P4estMesh and EC test #666

Merged
merged 7 commits into from
Jun 27, 2021

Conversation

efaulhaber
Copy link
Member

@efaulhaber efaulhaber commented Jun 24, 2021

Ninth point of #584.

In 3D, FSP only works in special cases for curved meshes (Kopriva et al., 2019, Section 6).
The three relevant cases (the other require different implementations) are:

  1. conforming meshes,
  2. two-dimensional extrusions,
  3. meshes with N >= 2*Ngeo, where Ngeo is the degree of the geometry interpolant (kwarg polydeg of P4estMesh) and N is the polynomial degree of the solver (kwarg polydeg of DGSEM).

Case 1 is boring. I added tests for case 2 and case 3.

I also made the mesh in the 2D FSP example non-conforming.

Edit: As requested by @sloede, I now added an EC test as well.

@efaulhaber efaulhaber requested a review from sloede June 24, 2021 22:24
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two remarks regarding the error norms.

test/test_examples_2d_p4est.jl Outdated Show resolved Hide resolved
test/test_examples_3d_p4est.jl Show resolved Hide resolved
@sloede
Copy link
Member

sloede commented Jun 25, 2021

Congratulations on the devilish PR number by the way 👿

@efaulhaber efaulhaber changed the title Add free stream preservation tests for non-conforming P4estMesh Add free stream preservation and EC tests for non-conforming P4estMesh Jun 25, 2021
@efaulhaber efaulhaber changed the title Add free stream preservation and EC tests for non-conforming P4estMesh Add free stream preservation tests for non-conforming P4estMesh and EC test Jun 25, 2021
@efaulhaber efaulhaber requested a review from sloede June 25, 2021 22:44
@codecov
Copy link

codecov bot commented Jun 26, 2021

Codecov Report

Merging #666 (e926993) into main (c3e0903) will increase coverage by 0.00%.
The diff coverage is 97.05%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #666   +/-   ##
=======================================
  Coverage   93.68%   93.69%           
=======================================
  Files         169      171    +2     
  Lines       16566    16600   +34     
=======================================
+ Hits        15520    15553   +33     
- Misses       1046     1047    +1     
Flag Coverage Δ
unittests 93.69% <97.05%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../elixir_advection_amr_p4est_unstructured_curved.jl 100.00% <ø> (ø)
...s/3d/elixir_advection_p4est_unstructured_curved.jl 100.00% <ø> (ø)
src/solvers/dg_curved/dg_3d.jl 97.20% <ø> (ø)
src/solvers/dg_tree/dg_3d.jl 97.48% <ø> (ø)
src/equations/compressible_euler_3d.jl 94.86% <80.00%> (-0.13%) ⬇️
examples/2d/elixir_euler_free_stream_p4est.jl 100.00% <100.00%> (ø)
examples/3d/elixir_euler_ec_p4est.jl 100.00% <100.00%> (ø)
examples/3d/elixir_euler_free_stream_p4est.jl 100.00% <100.00%> (ø)
...ples/3d/elixir_euler_free_stream_p4est_extruded.jl 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3e0903...e926993. Read the comment docs.

Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If someone else can confirm that the FSP numbers are OK, I think we're good to merge.

@andrewwinters5000
Copy link
Member

Great work @efaulhaber ! Everything looks good from my end with respect to the errors / testing. Also, everything is documented for the FSP restriction of N>=2N_geo

@efaulhaber efaulhaber deleted the p4est-fsp-tests branch September 25, 2021 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants