-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add free stream preservation tests for non-conforming P4estMesh
and EC test
#666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left two remarks regarding the error norms.
Congratulations on the devilish PR number by the way 👿 |
P4estMesh
P4estMesh
P4estMesh
P4estMesh
and EC test
Codecov Report
@@ Coverage Diff @@
## main #666 +/- ##
=======================================
Coverage 93.68% 93.69%
=======================================
Files 169 171 +2
Lines 16566 16600 +34
=======================================
+ Hits 15520 15553 +33
- Misses 1046 1047 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! If someone else can confirm that the FSP numbers are OK, I think we're good to merge.
Great work @efaulhaber ! Everything looks good from my end with respect to the errors / testing. Also, everything is documented for the FSP restriction of |
Ninth point of #584.
In 3D, FSP only works in special cases for curved meshes (Kopriva et al., 2019, Section 6).
The three relevant cases (the other require different implementations) are:
N >= 2*Ngeo
, whereNgeo
is the degree of the geometry interpolant (kwargpolydeg
ofP4estMesh
) andN
is the polynomial degree of the solver (kwargpolydeg
ofDGSEM
).Case 1 is boring. I added tests for case 2 and case 3.
I also made the mesh in the 2D FSP example non-conforming.
Edit: As requested by @sloede, I now added an EC test as well.