CompatHelper: bump compat for FillArrays to 1, (keep existing compat) #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ranocha
force-pushed
the
compathelper/new_version/2023-03-31-00-05-37-115-01294331447
branch
from
76efae3 to
58d3a74
Compare
Codecov Report
@@ Coverage Diff @@
## main #1380 +/- ##
=======================================
Coverage 95.96% 95.96%
=======================================
Files 344 344
Lines 28499 28499
=======================================
Hits 27347 27347
Misses 1152 1152
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
The windows tests seem to fail very consistently now... maybe there is an actual issue? The failed docs build (https://github.com/trixi-framework/Trixi.jl/actions/runs/4570148496/jobs/8067145007?pr=1380#step:6:1004) is due to #1378 |
|
If someone has Windows, it would be great to run tests locally. I suspect it's due to a larger RAM usage of Julia v1.8 compared to v1.7 and maybe reduced RAM available on newer Windows GitHub runers. |
ranocha
approved these changes
Apr 1, 2023
ranocha
deleted the
compathelper/new_version/2023-03-31-00-05-37-115-01294331447
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
FillArrayspackage from0.13.2to0.13.2, 1.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.